Open fast trace#73
Conversation
catappreciationhours2
force-pushed
the
open_fast_trace
branch
2 times, most recently
from
698194c to
bca50b8
Compare
Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
catappreciationhours2
force-pushed
the
open_fast_trace
branch
from
bca50b8 to
7033c26
Compare
Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
Co-authored-by: Kai Hudalla <sophokles.kh@gmail.com>
…matching and case branches
sophokles73
left a comment
sophokles73
left a comment
There was a problem hiding this comment.
Please first fix your EOL settings in your editor (VSCode?) to use UNIX EOL (\n). Then recreate the PR and make sure to include a proper license header in all files.
sophokles73
left a comment
sophokles73
left a comment
There was a problem hiding this comment.
Looks like the line endings are fixed 👍
Co-authored-by: Kai Hudalla <sophokles.kh@gmail.com>
Co-authored-by: Kai Hudalla <sophokles.kh@gmail.com>
|
We have one failing check because of requirements tracing. The way the oft checking file is written right now checks whether all requirements mentioned in adoc files have been implemented or not. Since we don't have all the functions written on this pr we have obviously not satisfied all the spec requirements at this moment. There are a few things we can try here -
@sophokles73 wondering if you have any idea how to progress from here |
|
I would suggest to follow the approach taken by the MQTT5 transport library |
Hey there @catappreciationhours2 -- do you have some thoughts here? Could you commit to clearing this up in the coming week? |
|
yes will take a look and redo this section |
…-transport-iceoryx2-rust into open_fast_trace
|
hey just pushed a change and all checks are passing. can you take a look and tell me if anything else needs to be done here? @PLeVasseur @sophokles73 |
|
@sophokles73 -- could you take a look? I may butcher an OFT review. |
|
|
||
| #[test] | ||
| // [specitem,oft-sid="dsn~up-transport-iceoryx2-service-name~1",oft-needs="utest"] | ||
| // [utest->dsn~up-transport-iceoryx2-service-name~1] |
There was a problem hiding this comment.
this correctly marks this test as implementing the required test for the dsn~up-transport-iceoryx2-service-name~1 specitem. However, you will also need to add a corresponding marker to code/function that actually implements the specitem using [impl->dsn~up-transport-iceoryx2-service-name~1] ...
|
Functionality was implemented in #78 |
4 participants
OpenFastTrace (OFT) integration to enable formal requirements tracing between the implementation of the Iceoryx2-based uTransport and the uProtocol specification (up-spec). This includes:
close #72